Skip to content

Remove hardcoded fallback version from VersionParser #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abraham merged 2 commits into from
Jan 30, 2026
Merged

Remove hardcoded fallback version from VersionParser #588

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1742abd
Initial plan
Copilot Jan 30, 2026
62e22b5
Remove hardcoded fallback min version, use config.json instead
Copilot Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/parsers/VersionParser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,11 @@ export class VersionParser {
/**
* Finds the maximum version from an array of version strings
* @param versions Array of version strings
* @returns The maximum version, or "4.3.0" as fallback if no versions found
* @returns The maximum version, or MINIMUM_VERSION as fallback if no versions found
*/
static findMaxVersion(versions: string[]): string {
if (!versions || versions.length === 0) {
return '4.3.0'; // Fallback to current hardcoded version
return MINIMUM_VERSION; // Fallback to minimum version from config
}

return versions.reduce((max, current) =>
Expand Down
Loading