Remove hardcoded fallback version from VersionParser#588
Merged
Conversation
Co-authored-by: abraham <3341+abraham@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove hardcoded fallback min version in VersionParser
Remove hardcoded fallback version from VersionParser
Jan 30, 2026
Copilot stopped work on behalf of
abraham due to an error
January 30, 2026 01:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
findMaxVersionmethod had a hardcoded'4.3.0'fallback that duplicated configuration already present inconfig.json.Changes
'4.3.0'withMINIMUM_VERSIONconstant infindMaxVersionfallbackThe
MINIMUM_VERSIONconstant already reads fromconfig.jsonat module initialization, maintaining a single source of truth for version configuration.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
otel.cloud.redocly.com/opt/hostedtoolcache/node/24.13.0/x64/bin/node node /home/REDACTED/work/mastodon-openapi/mastodon-openapi/node_modules/.bin/redocly lint --format=github-actions dist/schema.json(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.