Skip to content

Conversation

@rocky
Copy link
Collaborator

@rocky rocky commented Dec 8, 2024

Save relative to absolute file name mapping when doing "load" command, and in the debugger callback hook .

Resolve file paths in "backtrace" command.

rocky added 2 commits December 8, 2024 09:44
Save mapping when doing "load" command
resolve filename in "backtrace" command
@rocky rocky requested a review from jansorg December 8, 2024 15:37
@rocky
Copy link
Collaborator Author

rocky commented Dec 8, 2024

I should add a test case for this.

Copy link
Collaborator

@jansorg jansorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rocky Thank you very much!
This PR works well for my first use-case.
I may be too picky with quotes, but I've added a few code suggestions for quoting. Some were already in the code, I think.

rocky and others added 6 commits December 11, 2024 06:40
Co-authored-by: Joachim Ansorg <github@ja-dev.eu>
Co-authored-by: Joachim Ansorg <github@ja-dev.eu>
Co-authored-by: Joachim Ansorg <github@ja-dev.eu>
Co-authored-by: Joachim Ansorg <github@ja-dev.eu>
Co-authored-by: Joachim Ansorg <github@ja-dev.eu>
Co-authored-by: Joachim Ansorg <github@ja-dev.eu>
@rocky
Copy link
Collaborator Author

rocky commented Dec 11, 2024

@rocky Thank you very much! This PR works well for my first use-case.

Good to hear! Thanks for the confirmation.

I may be too picky with quotes, but I've added a few code suggestions for quoting. Some were already in the code, I think.

I appreciate the corrections. Let's get this as good as we can.

@rocky rocky merged commit f93e14b into bash-5.2 Dec 11, 2024
2 checks passed
jansorg added a commit that referenced this pull request Dec 27, 2024
* Resolve file paths in "backtrace"
* Save mapping when doing the "load" command; resolve the filename in  the "backtrace" command
* Add a test for the "load" command

---------

Co-authored-by: Joachim Ansorg <github@ja-dev.eu>
jansorg added a commit that referenced this pull request Dec 30, 2024
* Resolve file paths in "backtrace"
* Save mapping when doing the "load" command; resolve the filename in  the "backtrace" command
* Add a test for the "load" command

---------

Co-authored-by: Joachim Ansorg <github@ja-dev.eu>
rocky added a commit that referenced this pull request Dec 30, 2024
* Make -S --style option work...

And bump copyright

* Resolve filenames in `backtrace` command (#54)

* Resolve file paths in "backtrace"
* Save mapping when doing the "load" command; resolve the filename in  the "backtrace" command
* Add a test for the "load" command

---------

Co-authored-by: Joachim Ansorg <github@ja-dev.eu>

* Save more file information from initial call...

In particular, resolve the initial source directory and store that as
_Dbg_init_dir. Resolve the name of main bash program and add that to
canonicalized filenames.

* Update bashdb.in

Co-authored-by: Joachim Ansorg <github@ja-dev.eu>

* Update lib/hook.sh

Co-authored-by: Joachim Ansorg <github@ja-dev.eu>

* Update bashdb.in

Co-authored-by: Joachim Ansorg <github@ja-dev.eu>

* Add more places we resolve/expand files

In some cases though automatic file loading no longer happens.
In particular, on "list" and "break" commands.

* One more quoted statement.

---------

Co-authored-by: rocky <rb@dustyfeet.com>
Co-authored-by: R. Bernstein <rocky@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants