Expand filename shown in backtrace #51
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansorg
reviewed
Dec 6, 2024
Collaborator
jansorg
left a comment
jansorg
left a comment
There was a problem hiding this comment.
Thank you for working on this!
When I run this branch with my test sources, then I'm seeing this error.
I looked at it, but couldn't spot the problem.
For my review, only minor notes so far.
[jansorg@Island sources]$ ../../bashdb --style colorful -L ../.. main.bash
bash debugger, bashdb, release 5.2-1.1.2
Copyright 2002-2004, 2006-2012, 2014, 2016-2019, 2021, 2023-2024 Rocky Bernstein
This is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
** Internal debug error _Dbg_is_file(): file argument null
../../lib/filecache.sh: Zeile 247: _Dbg_filenames["$fullname"]: Falscher Feldindex.
hello world
Debugged program terminated normally. Use q to quit or R to restart.
bashdb<0>
| adjusted_pos=$(_Dbg_frame_adjusted_pos 0) | ||
| filename=$(_Dbg_file_canonic "${BASH_SOURCE[$adjusted_pos]}") | ||
| filename="${BASH_SOURCE[$adjusted_pos]}" | ||
| resolved_filename="${_Dbg_file2canonic[$filename]}" |
Collaborator
There was a problem hiding this comment.
should this have a local or typeset?
Collaborator
Author
There was a problem hiding this comment.
Yes, you are correct. Should be corrected now.
lib/file.sh
Outdated
| typeset dirname="${_Dbg_dir[i]}" | ||
| if [[ "$basename" == '\$cdir' ]] ; then | ||
| basename=$_Dbg_cdir | ||
| dirname=$_Dbg_cdir |
Collaborator
Author
There was a problem hiding this comment.
Yes, you are correct. Should be handled now.
lib/file.sh
Outdated
| dirname=$_Dbg_cdir | ||
| elif [[ "$basename" == '\$cwd' ]] ; then | ||
| basename=$(pwd) | ||
| dirname=$(pwd) |
Collaborator
Author
There was a problem hiding this comment.
Yes, you are correct; this should be handled now.
Co-authored-by: Joachim Ansorg <github@ja-dev.eu>
Collaborator
Author
|
Superseded by #54 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards addressing problem in screenshot 1. Regression tests fail, so more work is needed.