Fix to kick direction bug #1447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyamandel
requested review from
jeffriley,
pauldisberg and
reinhold-willcox
✅ COMPAS Build Successful!
Detailed Evolution PlotClick to view evolution plotGenerated by COMPAS CI |
pauldisberg
approved these changes
Dec 16, 2025
Collaborator
pauldisberg
left a comment
pauldisberg
left a comment
There was a problem hiding this comment.
Did a small run with "./COMPAS -n 1000 --mode BSE --main-sequence-core-mass-prescription BRCEK --muller-mandel-kick-multiplier-NS 630 --muller-mandel-sigma-kick-NS 0.45 --kick-direction-distribution ISOTROPIC --random-seed 1714388113". Distributions of theta and phi look as expected for isotropic kicks.
jeffriley
approved these changes
Dec 16, 2025
Collaborator
jeffriley
left a comment
jeffriley
left a comment
There was a problem hiding this comment.
Looks good - thanks @ilyamandel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #1446: Theta and phi variables are flipped when assigning kicks, potentially giving unintended kick distributions