Skip to content

Theta and phi variables are flipped when assigning isotropic kicks #1446

@ilyamandel

Description

@ilyamandel

Theta and phi variables are flipped when assigning isotropic kicks, potentially giving us unintended, non-isotropic kick distributions.

Discovered by @pauldisberg , easy fix but urgent.

Kicks are returned as (theta, phi), but incorrectly parsed as (phi, theta):

utils.cpp, DrawKickDirection():
return std::make_tuple(theta, phi);

Options.cpp:
std::tie(phi1, theta1) = utils::DrawKickDirection(m_KickDirectionDistribution.type, m_KickDirectionPower);
std::tie(phi2, theta2) = utils::DrawKickDirection(m_KickDirectionDistribution.type, m_KickDirectionPower);

Metadata

Metadata

Labels

bugSomething isn't workingseverity_moderateThis is a moderately severe bugurgency_highThis is a very urgent issue and should be resolved as soon as possible

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions