Skip to content

Comments

chore: emit vite manifest to support tophatting#1851

Merged
maxy-shpfy merged 1 commit intomasterfrom
02-23-poc_support_tophat_loader_in_index.html_for_staging
Feb 24, 2026
Merged

chore: emit vite manifest to support tophatting#1851
maxy-shpfy merged 1 commit intomasterfrom
02-23-poc_support_tophat_loader_in_index.html_for_staging

Conversation

@maxy-shpfy
Copy link
Collaborator

@maxy-shpfy maxy-shpfy commented Feb 23, 2026

Description

Contributes to https://github.com/Shopify/oasis-frontend/issues/180

Enabled manifest generation in the Vite build configuration by setting manifest: "assets-registry.json" in the build options. This will generate a manifest.json file during the build process that maps original asset names to their hashed output filenames.

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

  1. Run npm run build or equivalent build command
  2. Verify that a assets-registry.json file is generated in the build output directory
  3. Confirm that the manifest contains mappings of original asset names to their hashed filenames
  4. Test that the application still loads and functions correctly with the generated manifest

Additional Comments

This change enables better asset management and cache busting strategies by providing a manifest file that can be used by server-side applications to reference the correct hashed asset filenames.

This change is required to enable Tophating via CDN.

Copy link
Collaborator Author

maxy-shpfy commented Feb 23, 2026

@maxy-shpfy maxy-shpfy force-pushed the 02-23-poc_support_tophat_loader_in_index.html_for_staging branch from 269ddbe to a082ed9 Compare February 23, 2026 22:34
@maxy-shpfy maxy-shpfy marked this pull request as ready for review February 24, 2026 06:50
@maxy-shpfy maxy-shpfy requested a review from a team as a code owner February 24, 2026 06:50
Copy link
Collaborator Author

maxy-shpfy commented Feb 24, 2026

Merge activity

  • Feb 24, 10:48 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 24, 10:49 PM UTC: Graphite rebased this pull request as part of a merge.
  • Feb 24, 10:52 PM UTC: Graphite rebased this pull request as part of a merge.
  • Feb 24, 10:53 PM UTC: @maxy-shpfy merged this pull request with Graphite.

@maxy-shpfy maxy-shpfy force-pushed the 02-23-poc_support_tophat_loader_in_index.html_for_staging branch from a082ed9 to 44bd171 Compare February 24, 2026 22:49
@maxy-shpfy maxy-shpfy force-pushed the 02-23-poc_support_tophat_loader_in_index.html_for_staging branch from 44bd171 to a35cf3f Compare February 24, 2026 22:51
@maxy-shpfy maxy-shpfy merged commit 8f5b5f7 into master Feb 24, 2026
7 of 8 checks passed
@maxy-shpfy maxy-shpfy deleted the 02-23-poc_support_tophat_loader_in_index.html_for_staging branch February 24, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants