Skip to content

Comments

poc: consolidated settings page#1847

Draft
maxy-shpfy wants to merge 1 commit into02-22-chore_tophat_builds_for_pr_scopefrom
02-23-poc_consolidated_settings_page
Draft

poc: consolidated settings page#1847
maxy-shpfy wants to merge 1 commit into02-22-chore_tophat_builds_for_pr_scopefrom
02-23-poc_consolidated_settings_page

Conversation

@maxy-shpfy
Copy link
Collaborator

@maxy-shpfy maxy-shpfy commented Feb 23, 2026

Description

Refactored the settings functionality from modal dialogs to a dedicated settings page with sidebar navigation. The new settings page consolidates backend configuration, personal preferences, beta features, and secrets management into a single unified interface accessible via /settings route.

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

  1. Navigate to the app menu and click the Settings button (gear icon)
  2. Verify the settings page loads with sidebar navigation
  3. Test each settings section:
    • Backend: Configure backend URL, test connection, toggle environment/relative path options
    • Preferences: Toggle personal preference settings
    • Beta Features: Enable/disable beta feature flags
    • Secrets: Add, edit, and remove secrets (if secrets feature is enabled)
  4. Verify the back button returns to the previous page
  5. Test navigation between different settings sections using the sidebar

Additional Comments

This change improves the user experience by providing a more organized and accessible settings interface. The modal-based approach has been replaced with a proper page that allows for better organization of settings categories and easier navigation between different configuration options.

Copy link
Collaborator Author

maxy-shpfy commented Feb 23, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@maxy-shpfy maxy-shpfy mentioned this pull request Feb 23, 2026
8 tasks
@maxy-shpfy maxy-shpfy changed the base branch from 02-23-fake_vibrant_color_schema to graphite-base/1847 February 24, 2026 03:46
@maxy-shpfy maxy-shpfy force-pushed the 02-23-poc_consolidated_settings_page branch from 1ed3620 to fbc0220 Compare February 24, 2026 03:46
@maxy-shpfy maxy-shpfy changed the base branch from graphite-base/1847 to 02-22-chore_tophat_builds_for_pr_scope February 24, 2026 03:46
@github-actions
Copy link

github-actions bot commented Feb 24, 2026

🎩 To tophat this PR:

You can add the following URL parameter to your browser to tophat this PR:

`?tophat_location=02-23-poc_consolidated_settings_page/ed3e531`

@maxy-shpfy maxy-shpfy force-pushed the 02-23-poc_consolidated_settings_page branch from fbc0220 to fd793d9 Compare February 24, 2026 04:05
@maxy-shpfy maxy-shpfy force-pushed the 02-22-chore_tophat_builds_for_pr_scope branch 2 times, most recently from 9b6b0e9 to a2aaca5 Compare February 24, 2026 06:52
@maxy-shpfy maxy-shpfy force-pushed the 02-23-poc_consolidated_settings_page branch from fd793d9 to ed3ff29 Compare February 24, 2026 06:52
@maxy-shpfy maxy-shpfy force-pushed the 02-22-chore_tophat_builds_for_pr_scope branch from a2aaca5 to 8996093 Compare February 24, 2026 20:00
@maxy-shpfy maxy-shpfy force-pushed the 02-23-poc_consolidated_settings_page branch from ed3ff29 to 01865a4 Compare February 24, 2026 20:00
@maxy-shpfy maxy-shpfy force-pushed the 02-22-chore_tophat_builds_for_pr_scope branch from 8996093 to e0c8ad9 Compare February 24, 2026 20:10
@maxy-shpfy maxy-shpfy force-pushed the 02-23-poc_consolidated_settings_page branch 2 times, most recently from 2b730bb to 5042ff6 Compare February 24, 2026 20:44
@maxy-shpfy maxy-shpfy force-pushed the 02-22-chore_tophat_builds_for_pr_scope branch 2 times, most recently from eef7699 to 16c0ebf Compare February 24, 2026 21:35
@maxy-shpfy maxy-shpfy force-pushed the 02-23-poc_consolidated_settings_page branch from 5042ff6 to 865f701 Compare February 24, 2026 21:35
@maxy-shpfy maxy-shpfy force-pushed the 02-22-chore_tophat_builds_for_pr_scope branch 2 times, most recently from f06d71f to 2d2a9c5 Compare February 24, 2026 22:54
@maxy-shpfy maxy-shpfy force-pushed the 02-23-poc_consolidated_settings_page branch from 865f701 to ed3e531 Compare February 24, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant