Merged
Conversation
Owner
|
That's very smart! |
Contributor
Author
|
Thanks 🙂 I bumped node to the latest version to also see if it fixes the CI, as it was passing locally. |
Contributor
Author
|
I've reproduced it locally. The |
This version includes vercel/ncc#868 which fixes the ncc bug on Node>=18.
Contributor
Author
|
Ah sorry, I was still testing it, hence the draft state. There was a problem in a downstream repo with the fileMatches, they aren't showing up on the workflow. I hope we didn't break anything, I'd recommend to double check and do some tests before releasing. I'll try to continue tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
getVersionControlledFiles()to read git's output,execwas used to run git, causing issues like #271.This PR switches from
exectospawnwhich is more appropriate for large outputs.Further info:
https://stackoverflow.com/a/48698373
https://stackoverflow.com/a/26995407