Using this action in large repos#271
Merged
SvanBoxel merged 4 commits intoSvanBoxel:mainfrom Jan 4, 2023
Merged
Conversation
SvanBoxel
approved these changes
Jan 4, 2023
Owner
SvanBoxel
left a comment
SvanBoxel
left a comment
There was a problem hiding this comment.
Oh, wow, I hadn't thought of that but definitely makes sense. Thanks for the PR! Approved. :)
Contributor
|
Hello @SvanBoxel. We're using this action in an even larger codebase that requires a bigger number. Would it make sense to make it an action parameter ? |
Owner
|
Feel free to submit a PR to make it configurable with a sensible default. Thanks! |
Merged
Contributor
Actually, I found a better solution. Opened #276. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @SvanBoxel!
I am using this action in a large repo with many codeowners. I am running into an error of
Error: stdout maxBuffer length exceededcoming fromexecThe default
maxBuffervalue is1024 * 1024and I have changed it to1024 * 10000(10 mb).This is probably overkill for most use cases but it is necessary for very large codebases. Just thought I would flag this and propose an amendment. Let me know what you think.
Cheers!