Base default values for attributes on the entity's defaults, not the global ones. #8313
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
bug
sovdeeth
requested review from
Absolutionism and
Efnilite
and removed request for
a team
skriptlang-automation
bot
added
the
needs reviews
1 task
Efnilite
approved these changes
Dec 10, 2025
APickledWalrus
approved these changes
Dec 10, 2025
github-project-automation
bot
moved this from In Review
to Awaiting Merge
in 2.14 Releases
sovdeeth
added
patch-ready
github-project-automation
bot
moved this from Awaiting Merge
to Done - Awaiting Release
in 2.14 Releases
skriptlang-automation
bot
added
completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Resetting a player's walk speed would use the global attribute default of 0.7 rather than the player entity type default of 0.1. This may apply to many more attribute defaults.
Solution
Uses the entity type's getDefaultAttributes to determine the base attribute value, as is intended by Paper API. See the clarification and deprecation of the method we currently use here: PaperMC/Paper#13343
Testing Completed
Manual confirmation.
Supporting Information
Completes: #8097
Related: none
AI assistance: none