shopify app import-custom-data-definitions #6658
Open
+393
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 24, 2025
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
shauns
force-pushed
the
shauns/11-24-shopify_app_data_import-definitions
branch
from
240c3d5 to
37bd585
Compare
Contributor
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3489 tests passing in 1402 suites. Report generated by 🧪jest coverage report action from ee3bfb6 |
Contributor
|
/snapit |
Contributor
|
🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm. Test the snapshot by installing your package globally: npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20251126113029Caution After installing, validate the version by running just |
gonzaloriestra
approved these changes
Nov 26, 2025
Contributor
gonzaloriestra
left a comment
gonzaloriestra
left a comment
There was a problem hiding this comment.
The code LGTM and it works as expected, but I have some suggestions:
- The command is too slow because of the iteration through all the product types and the delays. Some ideas to make it faster:
- Get rid of the sleeps or reduce them
- Reduce the number of queries by skipping types with no access
- Run them concurrently
- Add a new API endpoint to fetch all of them in batch
- Why not updating the TOML directly instead of printing the changes? Most devs will have Git to check the changes. And we could add a
--dry-runflag to only print.
shauns
force-pushed
the
shauns/11-24-shopify_app_data_import-definitions
branch
from
37bd585 to
f0a920f
Compare
shauns
force-pushed
the
shauns/dcdd-import-service
branch
from
bd265d7 to
ac99e52
Compare
shauns
force-pushed
the
shauns/11-24-shopify_app_data_import-definitions
branch
from
f0a920f to
1a20071
Compare
5 tasks
shauns
changed the title
shauns
force-pushed
the
shauns/11-24-shopify_app_data_import-definitions
branch
from
1a20071 to
ee3bfb6
Compare
shauns
force-pushed
the
shauns/dcdd-import-service
branch
from
ac99e52 to
ae8cbbd
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/http.d.ts@@ -18,7 +18,7 @@ type AutomaticCancellationBehaviour = {
} | {
useAbortSignal: AbortSignal | (() => AbortSignal);
};
-type RequestBehaviour = NetworkRetryBehaviour & AutomaticCancellationBehaviour;
+export type RequestBehaviour = NetworkRetryBehaviour & AutomaticCancellationBehaviour;
export type RequestModeInput = PresetFetchBehaviour | RequestBehaviour;
/**
* Specify the behaviour of a network request.
packages/cli-kit/dist/public/node/api/graphql.d.ts@@ -47,6 +47,7 @@ export type GraphQLRequestDocOptions<TResult, TVariables> = GraphQLRequestBaseOp
}>>;
variables?: TVariables;
unauthorizedHandler?: UnauthorizedHandler;
+ autoRateLimitRestore?: boolean;
};
export interface GraphQLResponseOptions<T> {
handleErrors?: boolean;
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Adds
shopify app import-custom-data-definitions, a command to automatically convert existing metafields and metaobjects to declarative TOML.WHAT is this pull request doing?
Exposes the service from the downstack PR. The command uses the dev store, so this follows the same patterns as
app dev.How to test your changes?
Run
shopify app import-custom-data-definitionson an app that has some app-reserved definitions in its dev store. If you want to make one via GraphQL, this example is good.The command has an
--include-existingoption. If this is set, definitions already in the TOML will be included too. That's a very fast way of testing/iterating.Measuring impact
How do we know this change was effective? Please choose one:
Checklist