Skip to content

Conversation

@shauns
Copy link
Contributor

@shauns shauns commented Nov 21, 2025

WHY are these changes introduced?

To enable importing metafield and metaobject definitions from a shop into a TOML configuration file, making it easier for developers to migrate existing custom data structures into their app configuration.

The service loads metafield definitions across all owner types, as well as metaobject definitions. These are then converted into their TOML equivalent, and for finessed rendering, a collection of patches to apply to control TOML formatting.

This service is not exposed within this PR.

image.png

Copy link
Contributor Author

shauns commented Nov 21, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 79.4% 14072/17722
🟡 Branches 73.42% 6893/9389
🟡 Functions 79.63% 3620/4546
🟡 Lines 79.77% 13303/16676

Test suite run success

3489 tests passing in 1402 suites.

Report generated by 🧪jest coverage report action from ae8cbbd

@shauns shauns force-pushed the shauns/dcdd-import-service branch from cca80dc to 375e9d7 Compare November 21, 2025 13:04
@shauns shauns force-pushed the shauns/tasks-tokenized-title branch from ec968cf to 4d6099e Compare November 21, 2025 13:04
@shauns shauns force-pushed the shauns/dcdd-import-service branch 3 times, most recently from 232d079 to a61c3ab Compare November 21, 2025 14:21
Base automatically changed from shauns/tasks-tokenized-title to main November 21, 2025 14:59
@shauns shauns force-pushed the shauns/dcdd-import-service branch from a61c3ab to bd265d7 Compare November 24, 2025 10:35
Copy link
Contributor

@gonzaloriestra gonzaloriestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is a bit hard to follow, I would try to simplify in general.

Also, I would add some debug messages around to be able to investigate issues from verbose outputs.

I left some random suggestions, but nothing really important.

"{projectRoot}/src/cli/api/graphql/functions/generated/**/*.ts",
"{projectRoot}/src/cli/api/graphql/bulk-operations/generated/**/*.ts"
"{projectRoot}/src/cli/api/graphql/bulk-operations/generated/**/*.ts",
"{projectRoot}/src/cli/api/graphql/admin/generated/**/*.ts"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't we just replace all these with something like this?
"{projectRoot}/src/cli/api/graphql/**/generated/**/*.ts"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good shout. But let me add as a separate piece of stack -- there could be good reason, nx has its idiosyncrasies.

"pnpm eslint 'src/cli/api/graphql/functions/generated/**/*.{ts,tsx}' --fix",
"pnpm eslint 'src/cli/api/graphql/bulk-operations/generated/**/*.{ts,tsx}' --fix"
"pnpm eslint 'src/cli/api/graphql/bulk-operations/generated/**/*.{ts,tsx}' --fix",
"pnpm eslint 'src/cli/api/graphql/admin/generated/**/*.{ts,tsx}' --fix"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

"{projectRoot}/src/cli/api/graphql/functions/generated/**/*.ts",
"{projectRoot}/src/cli/api/graphql/bulk-operations/generated/**/*.ts"
"{projectRoot}/src/cli/api/graphql/bulk-operations/generated/**/*.ts",
"{projectRoot}/src/cli/api/graphql/admin/generated/**/*.ts"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here

@shauns shauns changed the base branch from main to graphite-base/6651 December 5, 2025 09:31
@shauns shauns force-pushed the shauns/dcdd-import-service branch from bd265d7 to ac99e52 Compare December 5, 2025 09:31
@shauns shauns changed the base branch from graphite-base/6651 to shauns/12-05-automatic_rate_limit_restoration_w__admin_api_calls December 5, 2025 09:31
@shauns shauns force-pushed the shauns/dcdd-import-service branch from ac99e52 to ae8cbbd Compare December 5, 2025 10:28
@shauns shauns force-pushed the shauns/12-05-automatic_rate_limit_restoration_w__admin_api_calls branch from 80c8dcb to 68d8802 Compare December 5, 2025 10:28
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/http.d.ts
@@ -18,7 +18,7 @@ type AutomaticCancellationBehaviour = {
 } | {
     useAbortSignal: AbortSignal | (() => AbortSignal);
 };
-type RequestBehaviour = NetworkRetryBehaviour & AutomaticCancellationBehaviour;
+export type RequestBehaviour = NetworkRetryBehaviour & AutomaticCancellationBehaviour;
 export type RequestModeInput = PresetFetchBehaviour | RequestBehaviour;
 /**
  * Specify the behaviour of a network request.
packages/cli-kit/dist/public/node/api/graphql.d.ts
@@ -47,6 +47,7 @@ export type GraphQLRequestDocOptions<TResult, TVariables> = GraphQLRequestBaseOp
     }>>;
     variables?: TVariables;
     unauthorizedHandler?: UnauthorizedHandler;
+    autoRateLimitRestore?: boolean;
 };
 export interface GraphQLResponseOptions<T> {
     handleErrors?: boolean;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants