Skip to content

Update .NET, PSReadLine, and Nuget packages #2262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andyleejordan merged 2 commits into from
Nov 25, 2025
Merged

Update .NET, PSReadLine, and Nuget packages #2262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
132f408
Update .NET, PSReadLine, and Nuget packages
andyleejordan Nov 25, 2025
c370752
Skip broken Pester unit test
andyleejordan Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,35 +1,35 @@
<Project>
<ItemGroup>
<PackageVersion Include="Microsoft.CSharp" Version="4.7.0" />
<PackageVersion Include="Microsoft.Extensions.FileSystemGlobbing" Version="9.0.8" />
<PackageVersion Include="Microsoft.Extensions.Logging" Version="9.0.8" />
<PackageVersion Include="Microsoft.Extensions.Logging.Debug" Version="9.0.8" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.14.1" />
<PackageVersion Include="Microsoft.Extensions.FileSystemGlobbing" Version="10.0.0" />
<PackageVersion Include="Microsoft.Extensions.Logging" Version="10.0.0" />
<PackageVersion Include="Microsoft.Extensions.Logging.Debug" Version="10.0.0" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
<PackageVersion Include="Microsoft.PowerShell.5.ReferenceAssemblies" Version="1.1.0" />
Copy link

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downgrading Microsoft.PowerShell.SDK from 7.5.2 to 7.4.13 appears to be a version rollback rather than an update. Please verify this is intentional. If compatibility issues exist with 7.5.2, consider documenting the reason for the downgrade.

Suggested change
<PackageVersion Include="Microsoft.PowerShell.5.ReferenceAssemblies" Version="1.1.0" />
<PackageVersion Include="Microsoft.PowerShell.5.ReferenceAssemblies" Version="1.1.0" />
<!-- Downgraded from 7.5.2 to 7.4.13 due to compatibility issues with [describe affected component or reason, e.g., "our build pipeline" or "dependency X"]. See [link to issue tracker or documentation if available]. -->

Copilot uses AI. Check for mistakes.
<PackageVersion Include="Microsoft.PowerShell.SDK" Version="7.5.2" />
<PackageVersion Include="Newtonsoft.Json" Version="13.0.3" />
<PackageVersion Include="Microsoft.PowerShell.SDK" Version="7.4.13" />
<PackageVersion Include="Newtonsoft.Json" Version="13.0.4" />
<PackageVersion Include="OmniSharp.Extensions.DebugAdapter.Client" Version="0.19.9" />
<PackageVersion Include="OmniSharp.Extensions.DebugAdapter.Server" Version="0.19.9" />
<PackageVersion Include="OmniSharp.Extensions.LanguageClient" Version="0.19.9" />
<PackageVersion Include="OmniSharp.Extensions.LanguageServer" Version="0.19.9" />
<PackageVersion Include="PowerShellStandard.Library" Version="5.1.1" />
<PackageVersion Include="Roslynator.Analyzers" Version="4.14.0">
<PackageVersion Include="Roslynator.Analyzers" Version="4.14.1">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageVersion>
<PackageVersion Include="Roslynator.CodeAnalysis.Analyzers" Version="4.14.0">
<PackageVersion Include="Roslynator.CodeAnalysis.Analyzers" Version="4.14.1">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageVersion>
<PackageVersion Include="Roslynator.Formatting.Analyzers" Version="4.14.0">
<PackageVersion Include="Roslynator.Formatting.Analyzers" Version="4.14.1">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageVersion>
<PackageVersion Include="System.IO.Pipes.AccessControl" Version="5.0.0" />
<PackageVersion Include="System.Runtime.InteropServices.RuntimeInformation" Version="4.3.0" />
<PackageVersion Include="System.Security.Principal" Version="4.3.0" />
<PackageVersion Include="System.Security.Principal.Windows" Version="5.0.0" />
<PackageVersion Include="System.ValueTuple" Version="4.6.0" />
<PackageVersion Include="System.ValueTuple" Version="4.6.1" />
<PackageVersion Include="xunit" Version="2.9.3" />
<PackageVersion Include="xunit.runner.visualstudio" Version="2.8.2" />
<PackageVersion Include="Xunit.SkippableFact" Version="1.5.23" />
Expand Down
13 changes: 9 additions & 4 deletions PowerShellEditorServices.build.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,16 @@ namespace Microsoft.PowerShell.EditorServices.Hosting
}
}

task RestorePsesModules -If (-not (Test-Path "module/PSReadLine") -or -not (Test-Path "module/PSScriptAnalyzer")) {
Write-Build DarkMagenta "Restoring bundled modules"
task RestorePsesModules {
# NOTE: When updating module versions, ensure they are also saved to the CFS feed
Save-PSResource -Path module -Name PSScriptAnalyzer -Version "1.24.0" -Repository $PSRepository -TrustRepository -Verbose
Save-PSResource -Path module -Name PSReadLine -Version "2.4.4-beta4" -Prerelease -Repository $PSRepository -TrustRepository -Verbose
if (-not (Test-Path "module/PSScriptAnalyzer")) {
Write-Build DarkMagenta "Restoring PSScriptAnalyzer module"
Save-PSResource -Path module -Name PSScriptAnalyzer -Version "1.24.0" -Repository $PSRepository -TrustRepository -Verbose
}
if (-not (Test-Path "module/PSReadLine")) {
Write-Build DarkMagenta "Restoring PSReadLine module"
Save-PSResource -Path module -Name PSReadLine -Version "2.4.5" -Repository $PSRepository -TrustRepository -Verbose
Copy link

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PSReadLine version is being updated from "2.4.4-beta4" (with -Prerelease flag) to "2.4.5" (without -Prerelease flag). Verify that version 2.4.5 is a stable release and not a prerelease version. If 2.4.5 is still a prerelease, the -Prerelease flag should be retained on line 129.

Suggested change
Save-PSResource -Path module -Name PSReadLine -Version "2.4.5" -Repository $PSRepository -TrustRepository -Verbose
Save-PSResource -Path module -Name PSReadLine -Version "2.4.5" -Prerelease -Repository $PSRepository -TrustRepository -Verbose

Copilot uses AI. Check for mistakes.
}
}

Task Build FindDotNet, CreateBuildInfo, RestorePsesModules, {
Expand Down
2 changes: 1 addition & 1 deletion global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"sdk": {
"version": "8.0.405",
"version": "8.0.416",
"rollForward": "latestFeature",
"allowPrerelease": false
}
Expand Down
2 changes: 1 addition & 1 deletion test/PowerShellEditorServices.Test.E2E/DebugAdapterProtocolMessageTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@ public async Task CanLaunchScriptWithCommentedLastLineAsync()
[SkippableFact]
public async Task CanRunPesterTestFile()
{
Skip.If(s_isWindows, "Windows CI Pester is broken.");
Skip.If(true, "Pester test is broken.");
/* TODO: Get this to work on Windows.
string pesterLog = Path.Combine(s_binDir, Path.GetRandomFileName() + ".log");

Expand Down
2 changes: 1 addition & 1 deletion test/PowerShellEditorServices.Test.E2E/LanguageServerProtocolMessageTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1098,7 +1098,7 @@ await PsesLanguageClient
}
}

[SkippableFact]
[Fact]
public async Task CanSendHoverRequestAsync()
{
string filePath = NewTestFile(testCommand);
Expand Down
2 changes: 1 addition & 1 deletion test/PowerShellEditorServices.Test/Language/CompletionHandlerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ public async Task CompletesVariableInFile()
Assert.Equal(CompleteVariableInFile.ExpectedCompletion, actual);
}

[SkippableFact]
[Fact]
public async Task CompletesAttributeValue()
{
(_, IEnumerable<CompletionItem> results) = await GetCompletionResultsAsync(CompleteAttributeValue.SourceDetails);
Expand Down
2 changes: 1 addition & 1 deletion test/PowerShellEditorServices.Test/Language/SymbolsServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,7 +901,7 @@ public void FindsSymbolsWithNewLineInFile()
AssertIsRegion(symbol.ScriptRegion, 27, 5, 27, 10);
}

[SkippableFact()]
[SkippableFact]
public void FindsSymbolsInDSCFile()
{
Skip.If(!isWindows, "DSC only works properly on Windows.");
Expand Down
Loading