Update .NET, PSReadLine, and Nuget packages #2262
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates .NET SDK, PSReadLine module, and various NuGet package dependencies. The changes also include test attribute corrections and modifications to the module restore logic to improve incremental builds.
- Updates .NET SDK from 8.0.405 to 8.0.416
- Upgrades several NuGet packages including Microsoft.Extensions., Roslynator., and Newtonsoft.Json
- Updates PSReadLine from 2.4.4-beta4 to 2.4.5 and refactors module restore logic
- Corrects test attributes: removes empty parentheses from
[SkippableFact()]and changes tests without skip conditions from[SkippableFact]to[Fact]
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| global.json | Updates .NET SDK version to 8.0.416 |
| Directory.Packages.props | Updates multiple NuGet packages including Microsoft.Extensions., Microsoft.NET.Test.Sdk, Microsoft.PowerShell.SDK, Newtonsoft.Json, Roslynator., and System.ValueTuple |
| PowerShellEditorServices.build.ps1 | Updates PSReadLine to 2.4.5, refactors RestorePsesModules task to check each module individually and improve incremental restore behavior |
| test/PowerShellEditorServices.Test/Language/SymbolsServiceTests.cs | Removes unnecessary empty parentheses from [SkippableFact()] attribute |
| test/PowerShellEditorServices.Test/Language/CompletionHandlerTests.cs | Changes [SkippableFact] to [Fact] for test without skip conditions |
| test/PowerShellEditorServices.Test.E2E/LanguageServerProtocolMessageTests.cs | Changes [SkippableFact] to [Fact] for test without skip conditions |
| test/PowerShellEditorServices.Test.E2E/DebugAdapterProtocolMessageTests.cs | Updates Pester test skip condition to always skip with clearer message |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| if (-not (Test-Path "module/PSReadLine")) { | ||
| Write-Build DarkMagenta "Restoring PSReadLine module" | ||
| Save-PSResource -Path module -Name PSReadLine -Version "2.4.5" -Repository $PSRepository -TrustRepository -Verbose |
There was a problem hiding this comment.
The PSReadLine version is being updated from "2.4.4-beta4" (with -Prerelease flag) to "2.4.5" (without -Prerelease flag). Verify that version 2.4.5 is a stable release and not a prerelease version. If 2.4.5 is still a prerelease, the -Prerelease flag should be retained on line 129.
| Save-PSResource -Path module -Name PSReadLine -Version "2.4.5" -Repository $PSRepository -TrustRepository -Verbose | |
| Save-PSResource -Path module -Name PSReadLine -Version "2.4.5" -Prerelease -Repository $PSRepository -TrustRepository -Verbose |
| <PackageVersion Include="Microsoft.Extensions.Logging" Version="10.0.0" /> | ||
| <PackageVersion Include="Microsoft.Extensions.Logging.Debug" Version="10.0.0" /> | ||
| <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.0.1" /> | ||
| <PackageVersion Include="Microsoft.PowerShell.5.ReferenceAssemblies" Version="1.1.0" /> |
There was a problem hiding this comment.
Downgrading Microsoft.PowerShell.SDK from 7.5.2 to 7.4.13 appears to be a version rollback rather than an update. Please verify this is intentional. If compatibility issues exist with 7.5.2, consider documenting the reason for the downgrade.
| <PackageVersion Include="Microsoft.PowerShell.5.ReferenceAssemblies" Version="1.1.0" /> | |
| <PackageVersion Include="Microsoft.PowerShell.5.ReferenceAssemblies" Version="1.1.0" /> | |
| <!-- Downgraded from 7.5.2 to 7.4.13 due to compatibility issues with [describe affected component or reason, e.g., "our build pipeline" or "dependency X"]. See [link to issue tracker or documentation if available]. --> |
Seems like a test is hung locally, seeing if it repros in CI.