-
Notifications
You must be signed in to change notification settings - Fork 61
Fix: revalidate workflow fields on external changes (Ctrl+Z) #4157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When Y.Doc updates a field value (e.g., via undo/redo or collaborative edits), trigger validation to clear stale errors. This fixes the issue where pressing Ctrl+Z to restore a valid value didn't clear the validation error message. Previously, field values updated but validation state persisted, leaving error messages visible even when values became valid again.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4157 +/- ##
=======================================
Coverage 89.02% 89.02%
=======================================
Files 425 425
Lines 19605 19605
=======================================
+ Hits 17453 17454 +1
+ Misses 2152 2151 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
doc-han
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just created an issue that defines this. updating the changelog
|
Thansk @doc-han, much more organised! And thanks @midigofrank for the review. |
Description
When Y.Doc updates a field value (e.g., via undo/redo or collaborative edits), trigger validation to clear stale errors. This fixes the issue where pressing Ctrl+Z to restore a valid value didn't clear the validation error message.
Previously, field values updated but validation state persisted, leaving error messages visible even when values became valid again.
Addresses point 2 of #4138
Validation steps
You can also test this in reverse -> ie using Ctrl + Z to make it so that field is blank to make sure the validation message appears + settings icon is red.
Additional notes for the reviewer
n/a
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Pre-submission checklist
:owner,:admin,:editor,:viewer)