Fix include merge empty list process variable #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iteration through a list with a merge include becomes incorrect if the number of elements the list changes due to the merge include.
twsearle
approved these changes
Apr 2, 2025
Contributor
twsearle
left a comment
twsearle
left a comment
There was a problem hiding this comment.
Thanks very much for getting this done so quickly! It all looks good to me, and I have tested it against the original yaml config and it resolves the issue there. Please let me know how we will get this deployed at the Met Office for PS47 trials.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Iteration through a list with a merge include becomes incorrect if the number of elements the list changes due to the merge include.
Issue(s) addressed
Resolves #35.
Checklist