Improve algorithm for merge include empty list #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewrmshin
changed the title
steoxley
approved these changes
Apr 2, 2025
Collaborator
steoxley
left a comment
steoxley
left a comment
There was a problem hiding this comment.
I've looked carefully through the changes and confirmed with Matt that if the offset was incorrect (off by one error) nothing would work. Good to merge!
twsearle
approved these changes
Apr 2, 2025
Contributor
twsearle
left a comment
twsearle
left a comment
There was a problem hiding this comment.
much cleaner very nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve on #36 and add test for merge include of empty dict.
Checklist