Skip to content

enhance: refactor knowhere ut by claude#1450

Open
foxspy wants to merge 2 commits intomainfrom
refactor_knowhere_ut_by_claude
Open

enhance: refactor knowhere ut by claude#1450
foxspy wants to merge 2 commits intomainfrom
refactor_knowhere_ut_by_claude

Conversation

@foxspy
Copy link
Collaborator

@foxspy foxspy commented Jan 28, 2026

issue: #1446
/kind improvement

- Add test_helpers.h: IndexTestHelper template class for reducing repetitive Build/Search code
- Add test_config_generators.h: Centralized ConfigGenerator class for all index configurations
- Add test_flat.cc: Dedicated Flat index tests (build, search, bitset, range search, serialization)
- Add test_distance_unit.cc: Unit tests for distance computation (L2, IP, L1, Linf)
- Add test_distance_datatypes.cc: Multi-datatype distance tests (fp16, bf16, int8)
- Add test_utility_components.cc: BlockingQueue and BitsetView unit tests

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
- Merge test_distance_unit.cc into test_distances.cc
- Merge test_distance_datatypes.cc into test_simd.cc
- Add sparse_utils unit tests (SparseRow, MaxMinHeap, GrowableVectorView, DocIdFilterByVector)
- Add HNSW edge case tests (empty graph, heavy filtering, iterator)
- Enable coverage reporting in CI workflow (with_coverage=True)
- Add codecov.yml configuration (70% global, 80% patch targets)
- Add scripts/run_incremental_coverage.sh for local coverage analysis

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@foxspy
Copy link
Collaborator Author

foxspy commented Feb 3, 2026

/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants