2dplot small improvements #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mairacanal
requested changes
Nov 4, 2021
Member
mairacanal
left a comment
mairacanal
left a comment
There was a problem hiding this comment.
Além da correção equivocada do typo, o padrão dos commits está completamente errado. Tem commits em português, tem commits que a label não é o nome da classe, mas sim, uma label genérica, como fix. De resto, acho que ficou bom.
Comment on lines
+1
to
+2
|
|
||
|
|
src/components/sideMenu/menus/EditMenu/menus/uPlot/types/scatter.js
Outdated
Show resolved
Hide resolved
| { | ||
| text: 'Embaixo', | ||
| value: 2 | ||
| }, { |
src/components/sideMenu/menus/EditMenu/menus/uPlot/types/scatter.js
Outdated
Show resolved
Hide resolved
mairacanal
requested changes
Nov 4, 2021
Grillo-0
suggested changes
Nov 5, 2021
Contributor
Grillo-0
left a comment
Grillo-0
left a comment
There was a problem hiding this comment.
Quando acaba a simulação o zoom pelo scroll n funciona direito e para voltar a funcionar alguma coisa tem que ser mexida na edição do plot
Math-42
force-pushed
the
2dplot-visual-improvement
branch
from
a38aea8 to
6758f77
Compare
mairacanal
requested changes
Nov 18, 2021
Member
mairacanal
left a comment
mairacanal
left a comment
There was a problem hiding this comment.
Esse PR saiu completamente do escopo. Tirar o Plotly do repositório deveria ser em outro PR, senão esse PR fica muito grande e sem escopo definido.
Além disso, comentários meus da primeira revisão ainda não foram solucionados.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Changes:
Adicionando pequenas modificações no plot 2D:
Correção do bug de remoção da última série.
Corrigindo typos.
Ajustando uso da escala log.
Remoção de incoêrencias entre o plot e o menu de edição.
Adicionando grid no visual inicial do plot.
Adicionando plugin de zoom com a roda do mouse.
closes #12
Testing