Skip to content

Conversation

@cloedu87
Copy link
Collaborator

@cloedu87 cloedu87 commented Dec 31, 2025

Pull Request

Description

  • new implementation of catalog of life taxonomy encoding, which replaces gbif taxonomy encoding
  • iucn redlist encoding is now handled over gbif v2 api
  • various tests and adaptions to the new code

Related Issue

#987

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update
  • Build/CI update
  • Other (please describe):

License Compliance

  • My changes comply with the GNU AGPL-3.0 license requirements
  • If my changes involve network interaction, I've ensured users can access the corresponding source code

… replaces gbif taxonomy encoding; iucn redlist encoding is now handled over iucn api directly and not over gbif api anymore; various tests and adaptions to the new code
@cloedu87 cloedu87 requested a review from sidler92 December 31, 2025 16:49
@cloedu87 cloedu87 self-assigned this Dec 31, 2025
@cloedu87 cloedu87 added enhancement New feature or request elixir Pull requests that update Elixir code db Changes affecting database layer labels Dec 31, 2025
@cloedu87 cloedu87 marked this pull request as draft December 31, 2025 16:50
@cloedu87
Copy link
Collaborator Author

cloedu87 commented Jan 5, 2026

ensure to have #999 merged first, then adjust tests and were TODOs are stated.


infofauna_request = Enum.find(validation_requests, &(&1.center == :infofauna))
swissfungi_request = Enum.find(validation_requests, &(&1.center == :swissfungi))
# TODO: adjusted this, until new swiss catalog registry is implemented
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be re-activated when #1016 is merged

@cloedu87
Copy link
Collaborator Author

cloedu87 commented Jan 6, 2026

implemented #1015

@cloedu87 cloedu87 marked this pull request as ready for review January 6, 2026 15:45
sidler92
sidler92 previously approved these changes Jan 7, 2026
Copy link
Contributor

@sidler92 sidler92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a bit hard for me to understand all the consequences of these changes, but on the surface it looks good to me and makes sense 👍

activity
|> Map.put(:content, %{tax_taxon_id: "1231231"})
|> Map.put(:source, "GBIF Taxonomy")
|> Map.put(:source, "OL Taxonomy")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes :-) should be CoL. Changing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

db Changes affecting database layer elixir Pull requests that update Elixir code enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants