Skip to content

Comments

YPE-1342: Removed mixed font family within footnotes popover #162

Merged
cameronapak merged 3 commits intomainfrom
jh/YPE-1342-footnotes-popover-has-mixed-font-family
Feb 20, 2026
Merged

YPE-1342: Removed mixed font family within footnotes popover #162
cameronapak merged 3 commits intomainfrom
jh/YPE-1342-footnotes-popover-has-mixed-font-family

Conversation

@jaredhightower-youversion
Copy link
Collaborator

Summary

This PR standardizes typography in the footnotes popover, ensuring that all displayed text uses the same font family.

Changes

  • Updated footnote popover content styling to consistently apply the intended serif font family.
  • Ensured verse preview text and note strings inside the popover render with matching font treatment.

Why

  • Popover content previously mixed font styles across different text blocks.
  • This change makes typography consistent and improves visual cohesion/readability.

@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@changeset-bot
Copy link

changeset-bot bot commented Feb 19, 2026

🦋 Changeset detected

Latest commit: 2bdf327

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@youversion/platform-react-ui Patch
@youversion/platform-core Patch
@youversion/platform-react-hooks Patch
nextjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 19, 2026

Greptile Summary

Added font-serif class to the footnote popover's verse HTML container to standardize typography across all text within the popover. This ensures the verse preview text uses the same serif font family as intended.

  • Added non-prefixed font-serif class alongside existing yv:font-serif on the verse HTML container (line 65)
  • Both classes appear to apply the same Source Serif 4 font, creating potential redundancy

Confidence Score: 4/5

  • Safe to merge - simple styling fix with minimal risk
  • Single-line CSS class change to improve typography consistency. The change is straightforward and low-risk, though having both yv:font-serif and font-serif appears redundant and could be simplified.
  • No files require special attention

Important Files Changed

Filename Overview
packages/ui/src/components/verse.tsx Added font-serif class alongside yv:font-serif to ensure consistent serif font in footnote popover verse preview. The redundant class may indicate a specificity or scoping issue that should be investigated.

Last reviewed commit: a79eaaa

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Copy link
Collaborator

@cameronapak cameronapak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this needs is a patch changeset and it's good to approve! @jaredhightower-youversion

Ensures that any nested elements within the verse notes also inherit the
serif font styling, maintaining consistent typography.
@jaredhightower-youversion jaredhightower-youversion force-pushed the jh/YPE-1342-footnotes-popover-has-mixed-font-family branch from 726b537 to 91f9932 Compare February 19, 2026 20:01
@cameronapak cameronapak merged commit c030f6c into main Feb 20, 2026
5 checks passed
@cameronapak cameronapak deleted the jh/YPE-1342-footnotes-popover-has-mixed-font-family branch February 20, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants