-
-
Notifications
You must be signed in to change notification settings - Fork 18
Graphing Improvements #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
app/src/main/java/net/youapps/calcyou/ui/components/AddNewFunctionDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/net/youapps/calcyou/ui/components/AddNewFunctionDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/net/youapps/calcyou/ui/components/AddNewFunctionDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/net/youapps/calcyou/ui/components/AddNewFunctionDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/net/youapps/calcyou/ui/components/AddNewFunctionDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/net/youapps/calcyou/ui/components/AddNewFunctionDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/net/youapps/calcyou/ui/components/AddNewFunctionDialog.kt
Outdated
Show resolved
Hide resolved
| onClick = onDismiss, | ||
| modifier = Modifier.align(Alignment.End) | ||
| ) { | ||
| Text(text = "Close") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Text(text = "Close") | |
| Text(text = stringResource(android.R.string.ok)) |
app/src/main/java/net/youapps/calcyou/ui/components/AddNewFunctionDialog.kt
Show resolved
Hide resolved
app/src/main/java/net/youapps/calcyou/data/evaluator/Defaults.kt
Outdated
Show resolved
Hide resolved
Bnyro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, this really looks like a bunch of great improvements! <3
I hope you're doing well, as I haven't heard from you in a while. I'd definitely love to see you back in our development team :)
It's really kind of you to say that! I've been quite busy since starting university. I wanted to focus on my studies, explore other fields, and work on a few personal projects. Now that the toughest semesters are behind me, I finally have some free time to contribute to open source again. However, my Android skills are a bit rusty since I haven't worked on it in a while, so please bear with me if there are any silly mistakes! Hope you’re doing well too :) |
I'm very happy to hear that :) No worries about the code style - I'm sure that you're doing pretty well with getting into Android development again, and I don't mind reviewing PRs :) |
Added new functions:
Added a cheat sheet to quickly look up available function syntax
Allow hiding functions
Visibility improvements (thicker lines for functions and axis) and a Legend showing currently visible functions