Skip to content

Conversation

@junhaoliao
Copy link
Member

@junhaoliao junhaoliao commented Dec 7, 2025

Description

As the title says.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

task

cd build/clp-package
./sbin/start-clp.sh
# observed the package was started successfully

Summary by CodeRabbit

  • Chores
    • Updated Redis service configuration in the deployment infrastructure.

✏️ Tip: You can customize this high-level summary in your review settings.

@junhaoliao junhaoliao requested a review from a team as a code owner December 7, 2025 11:08
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 7, 2025

Walkthrough

Updated Redis service configuration in Docker Compose to use a different file path. The volume mount target and redis-server command argument were changed from /usr/local/etc/redis/redis.conf to /etc/redis/redis.conf.

Changes

Cohort / File(s) Summary
Redis configuration path update
tools/deployment/package/docker-compose-all.yaml
Changed Redis service volume mount and command argument paths from /usr/local/etc/redis/redis.conf to /etc/redis/redis.conf

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly and specifically summarizes the main change: moving Redis config mount path from /usr/local/etc to /etc in the Docker Compose configuration.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@kirkrodrigues kirkrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the PR title, how about:

refactor(deployment): Mount Redis config to `/etc` instead of `/usr/local/etc` in CLP package Docker Compose (resolves #1738).

@junhaoliao junhaoliao changed the title refactor(deployment): Map Redis config to /etc instead of /usr/local/etc in Package Compose (resolves #1738). refactor(deployment): Mount Redis config to /etc instead of /usr/local/etc in CLP package Docker Compose (resolves #1738). Dec 8, 2025
@junhaoliao junhaoliao merged commit 280d714 into y-scope:main Dec 8, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants