Minor cleanups #42
Merged
Minor cleanups #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat would be trivial to re-implement or was clearly outdated; removed comments in Dispose patterns that served no purpose; rewrote a comment in ToEngine so that it referenced the Github issue that covered it; deleted DirectoryHelper since it's no longer used; changed an Exception type in a file to resolve its TODO comment about which Exception type should be used
oconnor0
reviewed
Feb 10, 2025
oconnor0
reviewed
Feb 10, 2025
…finalizer to App.cs to make it properly match the recommended Dispose pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly removing unneeded TODO comments and outdated commented-out code