Skip to content

Conversation

@mathuriga
Copy link
Contributor

Purpose

This PR adds send an email notification upon scan completions feature. In addition to this, filtering view scans based on product name also incorporated.

Goals

Send email notification upon scan completion
Filter scan based on product name

User stories

N/A

Release note

N/A

Documentation

N/A

Training

N/A

Certification

N/A

Marketing

N/A

Automation tests

  • Unit tests
    N/A
  • Integration tests
    N/A

Security checks

Samples

N/A

Related PRs

N/A

Migrations (if applicable)

N/A

Test environment

N/A

Learning

N/A

@mathuriga mathuriga changed the title send Email notification upon scan completiom Send email notification upon scan completion Jun 28, 2020
@ayomawdb ayomawdb self-requested a review August 28, 2020 05:13
@ayomawdb
Copy link
Member

ayomawdb commented Sep 7, 2020

Can we reuse the GmailApiUtil for this purpose? @mathuriga

@ayomawdb
Copy link
Member

ayomawdb commented Sep 7, 2020

Ok.. I think this PR was sent way before the Util was created. Approving this for now. Let's create a GitHub issue for future improvment

@ayomawdb
Copy link
Member

ayomawdb commented Sep 7, 2020

@mathuriga please check travis also before proceeding

@ayomawdb
Copy link
Member

@mathuriga Please check on the conflicts

margin-bottom: 15px;
margin-top: 15px;

}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}


@Override
public boolean clearScan(String id) {
@Override public boolean clearScan(String id) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@Override public boolean clearScan(String id) {
@Override
public boolean clearScan(String id) {

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants