Fix parameter type for Assert::isMap()
#331
Open
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`isMap` should accept `mixed` or `array<array-key, T>`, not `array<string, T>`. If the input was `array<string, T>`, we wouldn't need to use `Assert::isMap()`.
Contributor
|
Isn't |
Author
|
The |
Contributor
|
I guess it's implementation dependent (the static analysis tool), but yep, agree. |
1 task
shadowhand
requested changes
Dec 24, 2025
| * @psalm-assert array<string, T> $array | ||
| * | ||
| * @param array<string, T> $array | ||
| * @param mixed|array<array-key, T> $array |
Collaborator
There was a problem hiding this comment.
I think this should just be mixed. As in, remove the @param declaration because the actual type is already mixed $array.
| * @param array<string, T> $array | ||
| * @param mixed|array<array-key, T> $array | ||
| * | ||
| * @return array<string, T> |
Collaborator
There was a problem hiding this comment.
This is incorrect, it should be @return array<array-key, T>.
| * | ||
| * @template T | ||
| * | ||
| * @psalm-assert array<string, T> $array |
Collaborator
There was a problem hiding this comment.
Also, this should be array<array-key, T>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isMapshould acceptmixedorarray<array-key, T>, notarray<string, T>. If the input wasarray<string, T>, we wouldn't need to useAssert::isMap().