test(e2e): add case for package.json imports resolution #6715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
chenjiahan
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds e2e test coverage for Node.js package.json imports field resolution with wildcard patterns, complementing the existing pkg-imports test which covers exact mappings.
- Adds a new e2e test fixture that exercises wildcard import patterns (
#app/*mapping to./src/*.js) - Verifies import alias resolution works correctly in both development and build modes
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| e2e/cases/resolve/node-imports-field/src/index.js | Entry point that imports from #app/foo using the wildcard import pattern |
| e2e/cases/resolve/node-imports-field/src/foo.js | Module that exports the test message to verify resolution works |
| e2e/cases/resolve/node-imports-field/package.json | Configures the imports field with wildcard pattern (#app/* -> ./src/*.js) |
| e2e/cases/resolve/node-imports-field/index.test.ts | Test suite verifying the imports field resolution in both dev and build modes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chenjiahan
deleted the
codex/add-test-case-for-node-js-import-in-rsbuild
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
package.jsonimports field#app/*import alias resolves correctly in both dev and buildTesting
pnpmis not available in the environment)Codex Task