Skip to content

feat: expose hide_existing_credentials in bundle registration section (#786) #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Spomky merged 2 commits into from
Dec 20, 2025
+18 −1
Merged

feat: expose hide_existing_credentials in bundle registration section (#786) #787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
681ea4d
feat: expose hide_existing_credentials in bundle registration sectio…
tomasz-kusy Dec 7, 2025
8d4a67e
chore: update PHPStan baseline for hide_existing_credentials
Spomky Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .ci-tools/phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,6 +543,12 @@ parameters:
count: 2
path: ../src/symfony/src/DependencyInjection/Factory/Security/WebauthnFactory.php

-
rawMessage: Cannot access offset 'hide_existing_credentials' on mixed.
identifier: offsetAccess.nonOffsetAccessible
count: 1
path: ../src/symfony/src/DependencyInjection/Factory/Security/WebauthnFactory.php

-
rawMessage: Cannot access offset 'host' on mixed.
identifier: offsetAccess.nonOffsetAccessible
Expand Down Expand Up @@ -711,6 +717,12 @@ parameters:
count: 1
path: ../src/symfony/src/DependencyInjection/Factory/Security/WebauthnFactory.php

-
rawMessage: 'Parameter #10 $hideExistingCredentials of method Webauthn\Bundle\DependencyInjection\Factory\Security\WebauthnFactory::createAttestationRequestControllerAndRoute() expects bool, mixed given.'
identifier: argument.type
count: 1
path: ../src/symfony/src/DependencyInjection/Factory/Security/WebauthnFactory.php

-
rawMessage: 'Parameter #3 $config of method Webauthn\Bundle\DependencyInjection\Factory\Security\WebauthnFactory::getAssertionOptionsBuilderId() expects array<mixed>, mixed given.'
identifier: argument.type
Expand Down
7 changes: 6 additions & 1 deletion src/symfony/src/DependencyInjection/Factory/Security/WebauthnFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,9 @@ public function addConfiguration(NodeDefinition $builder): void
->arrayNode('registration')
->canBeEnabled()
->children()
->booleanNode('hide_existing_credentials')
->defaultTrue()
->end()
->scalarNode('profile')
->defaultValue('default')
->end()
Expand Down Expand Up @@ -347,6 +350,7 @@ private function createAttestationControllersAndRoutes(
$config['options_storage'],
$config['registration']['options_handler'],
$config['failure_handler'],
$config['registration']['hide_existing_credentials'],
);
if ($config['registration']['routes']['result_path'] !== null) {
$this->createResponseControllerAndRoute(
Expand Down Expand Up @@ -401,6 +405,7 @@ private function createAttestationRequestControllerAndRoute(
null|string $optionsStorageId,
string $optionsHandlerId,
string $failureHandlerId,
bool $hideExistingCredentials,
): void {
$controller = (new Definition(AttestationRequestController::class))
->setFactory([new Reference(AttestationControllerFactory::class), 'createRequestController'])
Expand All @@ -410,7 +415,7 @@ private function createAttestationRequestControllerAndRoute(
new Reference($optionsStorageId ?? OptionsStorage::class),
new Reference($optionsHandlerId),
new Reference($failureHandlerId),
true,
$hideExistingCredentials,
]);
$this->createControllerAndRoute(
$container,
Expand Down
Loading