WIP: Added the option to output contaminant reads to file#44
Draft
SteampunkIslande wants to merge 1 commit intowdecoster:masterfrom
Draft
WIP: Added the option to output contaminant reads to file#44SteampunkIslande wants to merge 1 commit intowdecoster:masterfrom
SteampunkIslande wants to merge 1 commit intowdecoster:masterfrom
Conversation
Owner
|
Hi, Thanks for contributing! I will look at the code you wrote. Did you perhaps benchmark the time your version takes compared to the latest release? Best, |
Author
I'm sorry, I didn't. There might indeed be a performance cost, but overall it seems to be working just fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That's a feature I needed, it would be nice to be able to output contaminant reads in a separate file.
This PR does exactly that, but there are a few points I'd like to discuss with the maintainers:
Anyway, thanks for reading this through, have a good day :)