fix plot.py to work with kaleido v1 #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
That seems great! Do you have any insights regarding this change in kallisto:
From https://pypi.org/project/kaleido/#:~:text=Migrating%20from%20v0%20to%20v1 |
microbemarsh
commented
Jul 23, 2025
Contributor
Author
microbemarsh
left a comment
microbemarsh
left a comment
There was a problem hiding this comment.
Chrome uncertainties
Comment on lines
+8
to
+11
| # bring in kaleido and ensure Chrome is installed | ||
| import kaleido | ||
| # this will download a small headless Chrome build the first time you run it | ||
| kaleido.get_chrome_sync() |
Contributor
Author
There was a problem hiding this comment.
@wdecoster This should resolve the chrome issue from what I understand.
Owner
|
Alright - that's great :-) Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#417
Updated
nanoplotter/plot.pyto use new kaleido v1 libraries/syntax.Performed minimal test with fresh pip install with a random file.fastq.gz. Test results can be found within this fork under
scripts/agm_test.Still need to update pip/conda builds to include this change.