Add placeholder tests for streams and operations#21
Merged
eywalker merged 15 commits intowalkerlab:mainfrom Jun 18, 2025
Merged
Add placeholder tests for streams and operations#21eywalker merged 15 commits intowalkerlab:mainfrom
eywalker merged 15 commits intowalkerlab:mainfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds placeholder tests for streams and operations while also performing minor package refactors and API enhancements.
- Introduces auto-generated tests (placeholders) for streams and operations.
- Refactors package structure and renames modules (e.g. mapper → mappers).
- Adds a new TransferCacher and extends hashing functionality with a name_override parameter.
Reviewed Changes
Copilot reviewed 90 out of 90 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/orcabridge/hashing/string_cachers.py | Added TransferCacher and introduced Redis logging for caching. |
| src/orcabridge/hashing/hashing_legacy.py | Updated inline comments for parameter renaming. |
| src/orcabridge/hashing/files.py | Reordered and adjusted imports. |
| src/orcabridge/hashing/file_hashers.py | Reordered import statements. |
| src/orcabridge/hashing/defaults.py | Added a helper to retrieve a composite hasher with a cacher. |
| src/orcabridge/hashing/core.py | Introduced name_override parameter and refined function hashing logic. |
| src/orcabridge/dj/*.py | Updated import paths and adjusted namespace references. |
| src/orcabridge/base.py | Made Operation and Tracker abstract; added claims_unique_tags logic. |
| pyproject.toml | Added new dependencies for pandas, pyyaml, pyarrow, polars, etc. |
| notebooks/*.ipynb | Minor adjustments to import statements and formatting. |
Comments suppressed due to low confidence (3)
src/orcabridge/hashing/core.py:777
- The function signature for 'get_function_signature' was updated with the 'name_override' parameter, but the docstring does not reflect this change. Please update the docstring to describe the new parameter and its purpose.
def get_function_signature(
src/orcabridge/base.py:310
- The docstring for 'claims_unique_tags' in SyncStream indicates that the method may return None if uniqueness cannot be determined, yet the signature specifies a boolean return type. Please clarify the intended behavior and update the docstring or return type accordingly.
def claims_unique_tags(self, *, trigger_run=True) -> bool:
src/orcabridge/hashing/string_cachers.py:685
- The logger is used in this file without an import or initialization, which could lead to a runtime error. Consider adding 'import logging' and initializing a logger (e.g., 'logger = logging.getLogger(name)') at the top of the file.
logger.info(f"Retrieved cached value from Redis for key {cache_key}")
brian-arnold
approved these changes
Jun 18, 2025
Collaborator
brian-arnold
left a comment
There was a problem hiding this comment.
Took a brief look through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mapper->mappersto reflect the fact it is a collection of multiple mappers).claims_unique_tagsto serve as a mechanism to determine claimed uniqueness of the tag values in a stream. Makes use of the Stream -> Invocation -> Operation -> Stream -> ... recursive patterns used in keys and identity_structure to infer the uniqueness of tags by climbing up the processing pipeline chain.FunctionPodandpipelinepickleable.