Ruff formatting and turn hashing into a subpackage#17
Merged
eywalker merged 35 commits intowalkerlab:mainfrom May 27, 2025
Merged
Ruff formatting and turn hashing into a subpackage#17eywalker merged 35 commits intowalkerlab:mainfrom
eywalker merged 35 commits intowalkerlab:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR applies Ruff-based formatting across the codebase and refactors the hashing logic into its own hashing subpackage for better organization.
- Removed unused imports and standardized import ordering everywhere
- Broke out hashing-related functions into
src/orcabridge/hashingand updated all import paths - Switched default tracker from
TrackertoGraphTrackerand updated project dependencies
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_hashing/generate_hash_examples.py | Clean up unused os and uuid imports |
| tests/test_hashing/generate_file_hashes.py | Remove unused os import |
| src/orcabridge/utils/stream_utils.py | Remove unused imports from typing and _collections_abc |
| src/orcabridge/utils/name.py | Drop unused introspection imports |
| src/orcabridge/types.py | Rename type alias L to TagValue for clarity |
| src/orcabridge/tracker.py | Remove threading import |
| src/orcabridge/stream.py | Clean up unused imports |
| src/orcabridge/store/safe_dir_data_store.py | Remove unused imports; simplify logging |
| src/orcabridge/store/file_ops.py | Drop unused time and Optional imports |
| src/orcabridge/store/dir_data_store.py | Refine except clause to IOError; enrich error log |
| src/orcabridge/mapper.py | Add # noqa: E731 to inline lambda |
| src/orcabridge/hashing/function.py | New module for function hashing |
| src/orcabridge/hashing/init.py | Expose new hashing symbols and reorder imports |
| src/orcabridge/file.py | Switch Sequence to Collection in annotations |
| src/orcabridge/dj/tracker.py | Remove unused List import |
| src/orcabridge/dj/mapper.py | Drop unused QuerySource import |
| src/orcabridge/init.py | Import and set DEFAULT_TRACKER to GraphTracker |
| pyproject.toml | Add dev dependency group with ruff |
| .vscode/settings.json | Remove project-specific VSCode settings |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hashinginto a sub-package to house the hashing-related logic that has now become too complex to be in a single module. If the complexity continues to grow, will consider migratinghashingto an entirely separate repository.