Add rockspec file for installing from the repo directly#59
Open
mtourne wants to merge 1 commit intowahern:masterfrom
Open
Add rockspec file for installing from the repo directly#59mtourne wants to merge 1 commit intowahern:masterfrom
mtourne wants to merge 1 commit intowahern:masterfrom
Conversation
Author
|
ps. open to constructive criticism beyond a thumbs up / down (: |
Collaborator
|
So far I've been maintaining the rockspec outside of the repo; I believe @wahern prefers to build+install via make. I'd prefer we kept the status quo; we just need a release... |
Author
|
My guess was that adding a separate option for installing as an added convenience could only be a plus, and never a downside. |
Collaborator
|
Release is up. http://luarocks.org/modules/daurnimator/luaossl/20161029-0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed master rather than the version on luarocks to fix this issue :
#53
Seemed easier to make the existing rockspec file work with the repo rather than figure out the build system