src/lib/socket.c: fix build with libressl >= 3.5.0#253
Open
ffontaine wants to merge 1 commit intowahern:masterfrom
Open
src/lib/socket.c: fix build with libressl >= 3.5.0#253ffontaine wants to merge 1 commit intowahern:masterfrom
ffontaine wants to merge 1 commit intowahern:masterfrom
Conversation
Fix the following build failure with libressl >= 3.5.0:
/nvmedata/autobuild/instance-26/output-1/build/lua-cqueues-20200726/src/lib/socket.c: In function 'compat_SSL_is_server':
/nvmedata/autobuild/instance-26/output-1/build/lua-cqueues-20200726/src/lib/socket.c:188:12: error: invalid use of incomplete typedef 'SSL' {aka 'struct ssl_st'}
188 | return ssl->server != NULL;
| ^~
/nvmedata/autobuild/instance-26/output-1/build/lua-cqueues-20200726/src/lib/socket.c: At top level:
/nvmedata/autobuild/instance-26/output-1/build/lua-cqueues-20200726/src/lib/socket.c:2543:1: error: variable 'bio_methods' has initializer but incomplete type
2543 | static BIO_METHOD bio_methods = {
| ^~~~~~
Fixes:
- http://autobuild.buildroot.org/results/823c9e27cdb8e01a048cb751287c01c5dc70f860
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
daurnimator
reviewed
Jul 4, 2022
|
|
||
| static BIO_METHOD *so_get_bio_methods() { | ||
| if (bio_methods == NULL) { | ||
| #ifndef LIBRESSL_VERSION_NUMBER |
Collaborator
There was a problem hiding this comment.
What libressl feature is this checking for?
It should be more explicit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the following build failure with libressl >= 3.5.0:
Fixes:
Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com