Skip to content

Conversation

@pchampin
Copy link
Contributor

@pchampin pchampin commented Dec 5, 2025

following the emerging consensus in #2

@pchampin pchampin requested review from franconi and niklasl December 5, 2025 14:51
@niklasl
Copy link
Contributor

niklasl commented Dec 5, 2025

Looks good! I just think the properties (rdf:propositionFormSubject, etc.) need to begin with a lower-case p to follow the usual convention (I've proposed those changes now).

Also, the file spec/ex-basicenc-output.ttl needs to be updated accordingly.

(N.B.: I've done the equivalent changes in w3c/rdf-schema#70.)

Copy link
Contributor

@niklasl niklasl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing case of properties to the conventional camelCase for properties (was PascalCase like for classes).

@pchampin
Copy link
Contributor Author

Looks good! I just think the properties (rdf:propositionFormSubject, etc.) need to begin with a lower-case p to follow the usual convention (I've proposed those changes now).

absolutely, that's an oversight (following a hasty search-replace-all).

Also, the file spec/ex-basicenc-output.ttl needs to be updated accordingly.

Good catch. Will do.

(N.B.: I've done the equivalent changes in w3c/rdf-schema#70.)

@pchampin
Copy link
Contributor Author

pchampin commented Dec 10, 2025

Just force-pushed to rebase onto the latest main.
edited ...and I blew it :-( Commit ae6af09 fixes this, and restore the PR as it was supposed to be.

following the emerging consensus in #2
@pchampin pchampin reopened this Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants