Skip to content

Fixing reduction operations#128

Open
Joao-Pedro-Cabral wants to merge 1 commit intovproc:mainfrom
Joao-Pedro-Cabral:redop
Open

Fixing reduction operations#128
Joao-Pedro-Cabral wants to merge 1 commit intovproc:mainfrom
Joao-Pedro-Cabral:redop

Conversation

@Joao-Pedro-Cabral
Copy link

Problems in the current implementation:

  • Synchronization bugs with the following instructions (register pack operation ends much later compared to pipeline wrapper).
  • Many extra cycles are spent shifting the result element within the result buffer.

Solution:

  • Write the result element directly to the lowest bits of the result buffer (no shift)

@ParkerJones567
Copy link
Contributor

This issue might still be present in vicuna2.0, please test with the current development branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants