Sourcery Starbot ⭐ refactored voightp/flask-mega-tutorial#1
Open
SourceryAI wants to merge 1 commit intovoightp:masterfrom
Open
Sourcery Starbot ⭐ refactored voightp/flask-mega-tutorial#1SourceryAI wants to merge 1 commit intovoightp:masterfrom
SourceryAI wants to merge 1 commit intovoightp:masterfrom
Conversation
SourceryAI
commented
Jan 31, 2024
Comment on lines
-65
to
+69
| auth = None | ||
| if app.config["MAIL_USERNAME"] or app.config["MAIL_PASSWORD"]: | ||
| auth = (app.config["MAIL_USERNAME"], app.config["MAIL_PASSWORD"]) | ||
| secure = None | ||
| if app.config["MAIL_USE_TLS"]: | ||
| secure = () | ||
| else: | ||
| auth = None | ||
| secure = () if app.config["MAIL_USE_TLS"] else None |
Author
There was a problem hiding this comment.
Function create_app refactored with the following changes:
- Move setting of default value for variable into
elsebranch [×2] (introduce-default-else) - Split conditional into multiple branches [×2] (
split-or-ifs) - Merge duplicate blocks in conditional [×2] (
merge-duplicate-blocks) - Remove redundant conditional [×2] (
remove-redundant-if) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-18
to
+20
| if os.system("pybabel init -i messages.pot -d app/translations -l " + lang): | ||
| if os.system( | ||
| f"pybabel init -i messages.pot -d app/translations -l {lang}" | ||
| ): |
Author
There was a problem hiding this comment.
Function register refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
| when = [] | ||
| for i in range(len(ids)): | ||
| when.append((ids[i], i)) | ||
| when = [(ids[i], i) for i in range(len(ids))] |
Author
There was a problem hiding this comment.
Function SearchableMixin.search refactored with the following changes:
- Convert for loop into list comprehension (
list-comprehension)
Comment on lines
-80
to
+78
| return "<User {}>".format(self.username) | ||
| return f"<User {self.username}>" |
Author
There was a problem hiding this comment.
Function User.__repr__ refactored with the following changes:
- Replace call to format with f-string (
use-fstring-for-formatting)
Comment on lines
-90
to
+88
| return "https://www.gravatar.com/avatar/{}?d=identicon&s={}".format( | ||
| digest, size | ||
| ) | ||
| return f"https://www.gravatar.com/avatar/{digest}?d=identicon&s={size}" |
Author
There was a problem hiding this comment.
Function User.avatar refactored with the following changes:
- Replace call to format with f-string (
use-fstring-for-formatting)
| payload = {} | ||
| for field in model.__searchable__: | ||
| payload[field] = getattr(model, field) | ||
| payload = {field: getattr(model, field) for field in model.__searchable__} |
Author
There was a problem hiding this comment.
Function add_to_index refactored with the following changes:
- Convert for loop into dictionary comprehension (
dict-comprehension)
| "/translate?api-version=3.0&from={}&to={}".format( | ||
| source_language, dest_language | ||
| ), | ||
| f"https://api.cognitive.microsofttranslator.com/translate?api-version=3.0&from={source_language}&to={dest_language}", |
Author
There was a problem hiding this comment.
Function translate refactored with the following changes:
- Replace call to format with f-string (
use-fstring-for-formatting)
| if form.validate_on_submit(): | ||
| user = User.query.filter_by(email=form.email.data).first() | ||
| if user: | ||
| if user := User.query.filter_by(email=form.email.data).first(): |
Author
There was a problem hiding this comment.
Function reset_password_request refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
Comment on lines
-131
to
+143
| if form.validate_on_submit(): | ||
| user = User.query.filter_by(username=username).first() | ||
| if user is None: | ||
| flash(_("User %(username)s not found.", username=username)) | ||
| return redirect(url_for("main.index")) | ||
| if user == current_user: | ||
| flash(_("You cannot follow yourself!")) | ||
| return redirect(url_for("main.user", username=username)) | ||
| current_user.follow(user) | ||
| db.session.commit() | ||
| flash(_("You are following %(username)s!", username=username)) | ||
| return redirect(url_for("main.user", username=username)) | ||
| else: | ||
| if not form.validate_on_submit(): | ||
| return redirect(url_for("main.index")) | ||
| user = User.query.filter_by(username=username).first() | ||
| if user is None: | ||
| flash(_("User %(username)s not found.", username=username)) | ||
| return redirect(url_for("main.index")) | ||
| if user == current_user: | ||
| flash(_("You cannot follow yourself!")) | ||
| return redirect(url_for("main.user", username=username)) | ||
| current_user.follow(user) | ||
| db.session.commit() | ||
| flash(_("You are following %(username)s!", username=username)) | ||
| return redirect(url_for("main.user", username=username)) |
Author
There was a problem hiding this comment.
Function follow refactored with the following changes:
- Swap if/else branches (
swap-if-else-branches) - Remove unnecessary else after guard condition (
remove-unnecessary-else)
Comment on lines
-151
to
+162
| if form.validate_on_submit(): | ||
| user = User.query.filter_by(username=username).first() | ||
| if user is None: | ||
| flash(_("User %(username)s not found.", username=username)) | ||
| return redirect(url_for("main.index")) | ||
| if user == current_user: | ||
| flash(_("You cannot unfollow yourself!")) | ||
| return redirect(url_for("main.user", username=username)) | ||
| current_user.unfollow(user) | ||
| db.session.commit() | ||
| flash(_("You are not following %(username)s.", username=username)) | ||
| return redirect(url_for("main.user", username=username)) | ||
| else: | ||
| if not form.validate_on_submit(): | ||
| return redirect(url_for("main.index")) | ||
| user = User.query.filter_by(username=username).first() | ||
| if user is None: | ||
| flash(_("User %(username)s not found.", username=username)) | ||
| return redirect(url_for("main.index")) | ||
| if user == current_user: | ||
| flash(_("You cannot unfollow yourself!")) | ||
| return redirect(url_for("main.user", username=username)) | ||
| current_user.unfollow(user) | ||
| db.session.commit() | ||
| flash(_("You are not following %(username)s.", username=username)) | ||
| return redirect(url_for("main.user", username=username)) |
Author
There was a problem hiding this comment.
Function unfollow refactored with the following changes:
- Swap if/else branches (
swap-if-else-branches) - Remove unnecessary else after guard condition (
remove-unnecessary-else)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run: