Closed
Conversation
Owner
|
approved by cherry-picking directly into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #66
The difficulty of finding a valid proof of work is exponential in the leading 0s so the payout should compensate accordingly. Previously, as the issue describes, we had a linear payout scheme which is heavily biased towards easy shares (Bitaxes rejoice!). This PR brings the payout in line with the mining difficulty.
The min and max values are hardcoded for now while we figure out the best way to coordinate configuration. I also added some simple tests. I created a new function called
calculate_work_in_rangeto make this backwards compatible with the code as it is for now.