Conversation
There was a problem hiding this comment.
let's remove all these changes to config files in /test
There was a problem hiding this comment.
unless they are necessary, which would really surprise me
There was a problem hiding this comment.
I reset them back to what they were previously 👍
devenv.nix
Outdated
| '' "bitcoind-testnet.log"; | ||
| '' "bitcoind-regtest.log"; | ||
| }; | ||
| bitcoind-setup = { |
There was a problem hiding this comment.
Not a fan of this as a separate process since it clutters the devenv dashboard. I think you can just call the script from the pool process block similar to how the polling loops work.
There was a problem hiding this comment.
Agreed, that's a better place to put it.
|
I tested this change by running Before approving this PR I would like to clean up the unnecessary devenv process and get some clarity on whether the 16 blocks are really required. I suspect there is some state being carried over from old runs to new runs. When I disable the bitcoind setup script it runs but never actually starts mining. I wonder if we can add an error message or something. Not a requirement to approve the PR. |
|
nice work! |
Closes #7
This PR:
justrecipes for:We need a wallet in order to generate blocks, so it also includes a setup script to ensure that a wallet exists and we have at least 16 blocks.