Skip to content

flake: add devenv packages to flake outputs#31

Closed
jurraca wants to merge 1 commit intovnprc:masterfrom
jurraca:devenv-flake
Closed

flake: add devenv packages to flake outputs#31
jurraca wants to merge 1 commit intovnprc:masterfrom
jurraca:devenv-flake

Conversation

@jurraca
Copy link
Contributor

@jurraca jurraca commented Mar 15, 2025

per https://devenv.sh/guides/using-with-flakes/#the-flakenix-file
This allows devenv to work with nix develop --no-pure-eval. I see you went down the road of modifying the devenv root but this works for me, i can devenv up and the processes start.

This seems to throw an InvalidTaskName for create-logs-dir but the directory seems to be created anyway, and logs are written there, so idk about that.

My main question would be why make this a flake at all? Devenv is for specifying dev environments so idk what flakes give you here, apart from having nix users be ready to roll.

@vnprc
Copy link
Owner

vnprc commented Mar 15, 2025

My goal was to enable a workflow to update and pin the bitcoind version. It's on a fork that gets frequently rebased and it seems to be broken every time I install on a new machine.

I don't think I need devenv inside nix develop that was a misunderstanding on my part.

@vnprc
Copy link
Owner

vnprc commented Mar 17, 2025

Thanks for the help @jurraca! I am not going to merge this change because I have realized that I don't need nix flakes so I have deleted the flake.nix file.

If my LLM is to be believed, I can't pin the version of a bitcoind fork, which is why bitcoind.nix exists with a manually pinned commit hash. Instead of converting to a flake, I created a just recipe to more easily manually update this hard coded commit hash.

Does that sound right?

@jurraca
Copy link
Contributor Author

jurraca commented Mar 17, 2025

sure that would work. You could do this with a flake but you'd still have to update the bitcoind commit hash anyway, so it's an equivalent workflow.

@jurraca jurraca closed this Mar 17, 2025
@vnprc vnprc mentioned this pull request Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants