Open
Conversation
…c#1055) * Include supported amounts instead of assuming the power of 2 The mint's signatory defines the amounts and the wallet, and the mint, when paying, should use them instead of assuming the supported amounts are 2^(0..32), which is not part of the spec. * Introduce FeeAndAmount struct
* fix: update TLS configuration to handle missing client certificates gracefully
* feat(cdk): add WebSocket authentication support with comprehensive configuration - Add WebSocket auth token injection for client connections - Implement server-side WebSocket authentication verification - Add configuration options for per-endpoint WebSocket auth types - Include comprehensive documentation and example configuration - Support clear, blind, and no-auth modes for WebSocket endpoin
Remove unnecessary mint info fetching and keyset refresh during mint addition, and improve error propagation in token restoration flow
* fix: handle fiat melt amount conversions * feat: add check that processor returns quote unit --------- Co-authored-by: thesimplekid <tsk@thesimplekid.com>
This reverts commit be7c836.
…ashubtc#1124) * token: add Token::token_secrets() and spending-condition helpers - New helpers on Token that do not require mint keysets: - spending_conditions() - p2pk_pubkeys() - p2pk_refund_pubkeys() - htlc_hashes() - locktimes() - Introduce token_secrets() to unify V3/V4 proof traversal and avoid duplication - Bypass short->long keyset-id mapping since only Secret is needed for conditions - Use &Secret for TryFrom to fix compile error
* fix(cdk): prevent duplicate blinded message processing with database constraints Add unique constraints on blinded_message column in both PostgreSQL and SQLite databases, and implement application-level checks to prevent duplicate blinded messages from being processed. Also ensure proper cleanup of melt requests after successful processing. * feat: db tests for unique * refactor(cdk-sql): consolidate blinded messages into blind signature table Migrate from separate blinded_messages table to unified blind_signature table. Add signed_time column and make c column nullable to track both pending blind messages (c=NULL) and completed signatures. Update insert/update logic to handle upsert scenarios for blind signature completion. * refactor(cdk-sql): remove unique constraint migration and filter queries for signed messages Remove database-level unique constraint on blinded_message and instead filter queries to only consider messages with signatures (c IS NOT NULL * refactor(database): improve blinded message duplicate detection using database constraints Replace manual duplicate checking with database constraint handling for better reliability and simplified code flow in melt request processing. * refactor(cdk-sql): optimize blind signature processing with batch queries Replace individual queries per blinded message with single batch query and HashMap lookup to eliminate N+1 query performance issue. * fix: signed time to swap sigs * refactor(cdk): split blinded message handling and improve duplicate detection - Split add_melt_request_and_blinded_messages into separate methods - Add blinded messages to database before signing in swap operations - Improve duplicate output detection with proper error handling - Make add_blinded_messages method accept optional quote_id for flexibility * refactor(cdk): add BlindedMessageWriter for improved transaction rollback - Add BlindedMessageWriter component for managing blinded message state - Implement proper rollback mechanisms in swap operations - Add delete_blinded_messages database interface for cleanup - Improve error handling with better state management
* fix: lnbits msats error * fix: lnbits msats error
* feat: added postgres to ffi
* Add prior signatures if they exist
2 tasks
vnprc
approved these changes
Oct 2, 2025
Owner
vnprc
left a comment
vnprc
left a comment
There was a problem hiding this comment.
assuming this commit is the real diff and all the other changes are from rebasing upstream main...LGTM ship it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Proposed changes
Notes to the reviewers
Suggested CHANGELOG Updates
CHANGED
ADDED
REMOVED
FIXED
Checklist
just final-checkbefore committing