add test to verify that MintQuoteMiningShare is issued#1
add test to verify that MintQuoteMiningShare is issued#1wilfredallyn wants to merge 1 commit intovnprc:hashpool2from
Conversation
vnprc
left a comment
vnprc
left a comment
There was a problem hiding this comment.
Looks great! After a quick discussion we determined that these quotes need to use CurrencyUnit("HASH").
Custom currency units are not well supported. Watch out for potential problems with this code I added: 0d11a5b
It's probably a good idea, but only exists on this fork. We can remove it if it creates a big enough problem.
Once you make that change I think this is good to merge.
Great work Larry!
|
|
||
| // Update the local quote state to Issued since was updated in process_mining_mint_request | ||
| let mut quote: MintQuoteMiningShareResponse<Uuid> = quote.into(); | ||
| quote.state = MintQuoteState::Issued; |
There was a problem hiding this comment.
Instead of assuming that process_mining_mint_request updated the state to Issued we should update that function to return the state of the quote and use it here to update our quote.
|
Looking at this again, I think we should delete the pubsub calls in These are redundant since we're not waiting to process the next step. So in the happy path we would fire three pubsub events at the same time. |
2 participants
Description
verify that MintQuoteMiningShare has state issued after created by mint
run test with
cargo test -p cdk test_mint_mining_share_quote_is_issued