Corrected type on bufputc #124
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Might be implicitly casted, good idea to correct anyway. |
Contributor
Author
|
Confirmed, implicit cast to char, still likely should be uint8_t or char to begin with. |
|
@andre-d 👍 anyway, your changes can't cleanly merge with |
GerHobbelt
pushed a commit
to GerHobbelt/soldout
that referenced
this pull request
Feb 11, 2021
Renderer API
dokutoku
pushed a commit
to dokutoku/sundown
that referenced
this pull request
Mar 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible vulnerabilityimplicit cast, my bad