Fix for rogue spell "Sap" bug #2509

[ivgrekow]

🍰 Pullrequest

This PR is intended to fix current bug of rogue's sap spell

Proof

I found recorded let's play video on YouTube where guy was leveling his rogue. Seems it was on official Blizzard server. Proof that target creature can not hit rogue at the same time when Sap is casted can be found at 48:48 in this video:
https://www.youtube.com/watch?v=hxRG8ZxY0Kk&list=PLgGT669C539nz2VHu9yY5q8va7XW6njLO&index=5

Issues

• fixes 🐞 [Bug]Sap #2509

How2Test

Test 1 (without "Improved Sap" talents):

1. Enter stealth mode playing rogue
2. Select some humanoid creature and cast Sap
3. Ensure that target creature doesn't hit you at the same moment of spell cast (visually or via combat log)

Test 2 (with "Improved Sap" 3/3): same steps but you will have to spam sap until you get 10% proc of stealth removing. In this case the behavior is same as in previous test.

Todo / Checklist

• Perhaps it can potentially affect BattleBots.

[DSkywalk]

I think you missing add script to the AddSC_rogue_spell_scripts :?

    newscript = new Script;
    newscript->Name = "spell_rogue_sap";
    newscript->GetSpellScript = &GetScript_RogueSap;
    newscript->RegisterSelf();

[ivgrekow]

I think you missing add script to the AddSC_rogue_spell_scripts :?

    newscript = new Script;
    newscript->Name = "spell_rogue_sap";
    newscript->GetSpellScript = &GetScript_RogueSap;
    newscript->RegisterSelf();

Thank you! I tested the fix on local branch and really just forgot to add the registering code to this branch.