Skip to content

Conversation

@ivanium
Copy link
Contributor

@ivanium ivanium commented Dec 6, 2025

Purpose

Clean up the v1 scheduler by removing an unused req_index += 1 increment that remained after refactoring the waiting-queue scheduling logic.
This line no longer affects control flow (the index is not used in this loop) and could be confusing.

Test Plan

  • Run existing scheduler unit tests to confirm no behavior changes.
    • e.g. pytest tests/v1/core -q (or a narrower subset that exercises Scheduler scheduling paths)

Test Result

Succeeded.


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

…uests

Signed-off-by: Yifan Qiao <yifanqiao@berkeley.edu>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes an unused increment of the req_index variable within the schedule method of the Scheduler class. The variable was used for iterating over running requests in a previous loop but was also being incremented in the subsequent loop for waiting requests, where it has no effect. This change is a good cleanup that improves code clarity by removing dead code. The change is correct and I approve it.

@mergify mergify bot added the v1 label Dec 6, 2025
@ivanium ivanium marked this pull request as ready for review December 6, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant