Skip to content

Conversation

@junpuf
Copy link
Contributor

@junpuf junpuf commented Dec 5, 2025

Purpose

Fix a dependency issue.

When running uv pip install -r requirements/common.txt -r requirements/dev.txt --torch-backend=auto, I see below error:

  × No solution found when resolving dependencies:
  ╰─▶ Because model-hosting-container-standards==0.1.9 depends on
      starlette>=0.49.1 and only model-hosting-container-standards<=0.1.9 is
      available, we can conclude that model-hosting-container-standards>=0.1.9
      depends on starlette>=0.49.1.
      And because you require model-hosting-container-standards>=0.1.9
      and starlette==0.46.2, we can conclude that your requirements are
      unsatisfiable.

Regenerated requirements/test.txt file with uv pip compile requirements/test.in -o requirements/test.txt --index-strategy unsafe-best-match --torch-backend cu129 --python-platform x86_64-manylinux_2_28 --python-version 3.12.

The new test.txt has starlette==0.50.0 which satisfies starlette>=0.49.1 requirement.

Test Plan

Full CI Test

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Junpu Fan <junpu@amazon.com>
@mergify mergify bot added the ci/build label Dec 5, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily updates numerous Python package dependencies in requirements/test.txt to newer versions. Key updates include absl-py to 2.3.1, accelerate to 1.12.0, aiohttp to 3.13.2, fastapi to 0.123.10, huggingface-hub to 0.36.0, lightning to 2.6.0, mlflow and mlflow-skinny to 3.7.0, pandas to 2.3.3, peft to 0.18.0, plotly to 6.5.0, pytest to 9.0.1, pytorch-lightning to 2.6.0, ray to 2.52.1, scikit-learn to 1.7.2, and sentence-transformers to 5.1.2. Additionally, several new packages were added, such as annotated-doc, choreographer, cryptography, huey, logistro, mlflow-tracing, narwhals, polars-runtime-32, python-dotenv, pytokens, simplejson, and typeguard. Conversely, packages like dnspython, docstring-parser, email-validator, importlib-resources, markdown, sniffio, tensorboardx, tomli, tomli-w, types-python-dateutil, and typeshed-client were removed from the dependencies.

@DarkLight1337 DarkLight1337 added the ready-run-all-tests Trigger CI with all tests for wide-ranging PRs label Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready-run-all-tests Trigger CI with all tests for wide-ranging PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants