update torchao safetensors impl #30155
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a bug in the torchao safetensors loading implementation where the state_dict was not being reset for each file in a sharded checkpoint. The added initialization ensures that each file is processed independently, preventing incorrect weight accumulation. I've also pointed out a small follow-up cleanup to remove a now-redundant variable initialization, which will improve maintainability.
Signed-off-by: Angel Li <liangel@meta.com>
jerryzh168
approved these changes
Dec 5, 2025
Contributor
Author
|
cc @mgoin can you pls take a look, thanks! |
Contributor
|
Hi @mgoin can you take a look / stamp |
DarkLight1337
added
the
ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously
state_dictwasn't being reset after items were processedtests
all unit tests pass, E2E testing with torchao eval scripts also pass