-
-
Notifications
You must be signed in to change notification settings - Fork 11.8k
[Renderer] Separate out RendererConfig from ModelConfig
#30145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+971
−799
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
80cf80b
[Refactor] Separate out `RendererConfig` from ModelConfig`
DarkLight1337 5d7b31e
Also move `media_io_kwargs`
DarkLight1337 34f6d8c
Fix
DarkLight1337 33e0d97
Fix
DarkLight1337 cd3fa6f
Fix
DarkLight1337 4fe9c07
Fixes
DarkLight1337 9eb6d28
Fixes
DarkLight1337 b88ad60
Skip validation to pass doc build
DarkLight1337 da64ef3
Typo
DarkLight1337 9bff3a0
Fix arg
DarkLight1337 e46256e
Fix
DarkLight1337 468274f
Fix protocol
DarkLight1337 916b051
Fix
DarkLight1337 578527a
Typo
DarkLight1337 b299583
Update
DarkLight1337 713a0c6
Improve type annotation
DarkLight1337 e4df022
Merge branch 'main' into renderer-config
DarkLight1337 bee2e25
Merge branch 'main' into renderer-config
DarkLight1337 7c2913d
Fix intialization for tests
DarkLight1337 2055a7f
Fix
DarkLight1337 fbc6e71
Fix
DarkLight1337 7498f24
Avoid breaking compat with lm-eval
DarkLight1337 6879564
Merge branch 'main' into renderer-config
DarkLight1337 423b2ca
Fixes
DarkLight1337 e1e05d4
Fix mutable default
DarkLight1337 9382291
Fix
DarkLight1337 b94a407
Fix
DarkLight1337 ee458d6
Fix entrypoints test
DarkLight1337 c1db821
Merge branch 'main' into renderer-config
DarkLight1337 b20a2aa
Merge branch 'main' into renderer-config
DarkLight1337 1d3ca9b
Fix
DarkLight1337 5da9f1a
Pass the test
DarkLight1337 3e9e9cf
Fix
DarkLight1337 78b918b
Fix wrong model ID
DarkLight1337 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.