In-place parsing mode and unit-tests#25
Open
demartinofra wants to merge 9 commits intovincenthz:masterfrom
Open
In-place parsing mode and unit-tests#25demartinofra wants to merge 9 commits intovincenthz:masterfrom
demartinofra wants to merge 9 commits intovincenthz:masterfrom
Conversation
As per the previous implementation an event related to the parsing of a primitive value was raised only when the comma separator was encountered. With the new implementation the event is raised as soon as the parsing of the value is completed
… multiple parser calls
In some edge cases, namely when a number immediatly preceeds a closing bracketi, the parser (in IN_PLACE mode) was returning the wrong position of the buffer on close array/object events. The events sequence was correctly produced though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the following features to the library (mostly related to event based parsing mode) and since they are backward compatible with the current library API I thought it might be a good idea to merge them into upstream:
To Do:
Cheers,
Francesco